Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): add Neovim plugin #552

Merged
merged 14 commits into from
Aug 28, 2024
Merged

feat(docs): add Neovim plugin #552

merged 14 commits into from
Aug 28, 2024

Conversation

shivay-at-pieces
Copy link
Contributor

#550

  • Landing page
  • Install Guide
  • Commands

@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview Aug 28, 2024 4:55am

@Bishoy-at-pieces
Copy link
Contributor

Amazing stuff here thank you Shivay!! It looks great, I won't merge it rn I would like to wait to publish neovim

@Bishoy-at-pieces
Copy link
Contributor

Bishoy-at-pieces commented Aug 21, 2024 •
edited
Loading

Also might need to add that they need to run the :UpdateRemotePlugins every update, I will implement that logic also on my side to remind the user

@shivay-at-pieces
Copy link
Contributor Author

Amazing stuff here thank you Shivay!! It looks great, I won't merge it rn I would like to wait to publish neovim

Yes that is fine Bishoy, we also need to get the Neovim starter video ready!

jimbobbennett
jimbobbennett requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@jimbobbennett jimbobbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for copy only, not tested

docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/index.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/troubleshooting.mdx Outdated Show resolved Hide resolved
jimbobbennett
jimbobbennett requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@jimbobbennett jimbobbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More spelling

docs/extensions-plugins/neovim/troubleshooting.mdx Outdated Show resolved Hide resolved
jimbobbennett
jimbobbennett requested changes Aug 21, 2024
View reviewed changes
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
docs/extensions-plugins/neovim/quickstart.mdx Outdated Show resolved Hide resolved
mason-at-pieces
mason-at-pieces requested changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@mason-at-pieces mason-at-pieces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be the last from me

docs/extensions-plugins/neovim/quickstart.mdx Show resolved Hide resolved
docs/extensions-plugins/neovim/commands.mdx Outdated Show resolved Hide resolved
Bishoy-at-pieces
Bishoy-at-pieces reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Bishoy-at-pieces Bishoy-at-pieces left a comment •
edited by shivay-at-pieces
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there is a PR currently in review.
New 5 commands need to be documented

  • :PiecesLogin
  • :PiecesLogout
  • :PiecesConnectCloud
  • :PiecesDisconnectCloud
  • :PiecesAuthStatus (work in progress)
    @shivay-at-pieces

mason-at-pieces
mason-at-pieces approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@mason-at-pieces mason-at-pieces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bishoy-at-pieces
Copy link
Contributor

@jimbobbennett want to merge this in some hours

@mason-at-pieces mason-at-pieces merged commit e080d76 into pieces-app:main Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mason-at-pieces mason-at-pieces mason-at-pieces approved these changes

@jimbobbennett jimbobbennett Awaiting requested review from jimbobbennett

@Bishoy-at-pieces Bishoy-at-pieces Awaiting requested review from Bishoy-at-pieces

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shivay-at-pieces @Bishoy-at-pieces @jimbobbennett @mason-at-pieces