abstract localstorage useage #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unegbuclinton
requested review from
shivay-at-pieces,
Arindam-at-Pieces and
mason-at-pieces
as code owners
|
Hey @unegbuclinton thanks for the contribution. Do you mind resolving the merge conflict. |
|
@shivay-at-pieces thank you for reaching out, merge conflict has now been resolved. |
Arindam200
reviewed
Jul 25, 2024
src/app/utils/useVersion.tsx
Outdated
There was a problem hiding this comment.
As we are not returning any Jsx, it's better to rename the file as useVersion.ts
There was a problem hiding this comment.
got it, file is now renamed to useVersion.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a separate hook for accessing and updating OS versions from local storage, so as to make Indicator.tsx cleaner and testable.
Issue #125
Changes:
Create a useVersion hook to handle accessing local storage
Update Indicator.tsx to use hook to access Version in local storage