Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Home Assistant 2024.8 #1471

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Add compatibility with Home Assistant 2024.8 #1471

merged 3 commits into from
Jul 18, 2024

Conversation

piitaya
Copy link
Owner

@piitaya piitaya commented Jul 17, 2024

Breaking change

Some default themes variables has been changed to better fit Home Assistant 2024.8 grid system. Internal DOM structure of card may be changed too.
You need 2024.8HA Version to run this version.

Description

Align Mushroom card with grid and tile card specification.

Card height has been reduced from 66px to 56px.
Control height has been increased from 40px to 42px
Content spacing and control are now different (from 10px to 12px and 10px)

If you're using theme variables, you might take a look at these changes

Before

--mush-spacing: 12px
--mush-control-height: 40px
--mush-icon-size: 40px

After

--mush-spacing: 10px
--mush-control-height: 42px
--mush-control-spacing: 12px   # New variable
--mush-icon-size: 36px

Related Issue

This PR fixes or closes issue: fixes #

Motivation and Context

How Has This Been Tested

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚙️ Tech (code style improvement, performance improvement or dependencies bump)
  • 📚 Documentation (fix or addition in the documentation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.
  • I followed the steps if I add a new language .

@piitaya piitaya added the bug Something isn't working label Jul 17, 2024
@piitaya piitaya force-pushed the card-size-2024-8 branch from 4f01e2c to 3097c75 Compare July 18, 2024 10:03
@piitaya piitaya merged commit db0cfe1 into main Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant