feat(alarm): show keypad only for disarming #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we transform the boolean to a select ( |
Sure! Done in 5a0f502. |
rogelio-o
force-pushed
the
feat/alarm-show-keypad-disarm
branch
from
0181308 to
af1b875
Compare
|
@rogelio-o was this actually released? No |
rogelio-o
force-pushed
the
feat/alarm-show-keypad-disarm
branch
from
af1b875 to
3c20e1a
Compare
|
@piitaya I've rebased the branch and fixed the conflicts. Can you take a look? Thanks |
piitaya
requested changes
Oct 15, 2023
| "show_keypad": "Show keypad", | ||
| "always": "Always", | ||
| "never": "Never", | ||
| "disarm": "Disarmed" |
There was a problem hiding this comment.
Suggested change
| "disarm": "Disarmed" | |
| "disarm": "Disarm only" |
| "show_keypad": "Mostrar teclado", | ||
| "always": "Siempre", | ||
| "never": "Nunca", | ||
| "disarm": "Desarmado" |
There was a problem hiding this comment.
Should be "disarm only", not "disarmed"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new configuration property in the alarm card to show the keypad only for disarming (when the alarm is not disarmed).
Related Issue
787 - [Feature]: show keypad only for disarming in alarm card
Motivation and Context
To improve the alarm card. There are alarms that can be configured only for requiring the code for disarming (e.g., securitas)
How Has This Been Tested
With my Home Assistant instance.
Types of changes
Checklist