-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move perftests reporting on PRs to alps #1255
base: main
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of initial comments. I understand this is still work in progress, so I'll have a closer look later.
Don't forget to remove the scripts from the .jenkins
directory as well.
- export MIMALLOC_EAGER_COMMIT_DELAY=0 | ||
- python3 -m venv ~/venv_perftests | ||
- source ~/venv_perftests/bin/activate | ||
- python3 -m pip install $(cat $SOURCE_DIR/tools/perftests_ci/requirements.txt | grep -v \#) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work?
- python3 -m pip install $(cat $SOURCE_DIR/tools/perftests_ci/requirements.txt | grep -v \#) | |
- python3 -m pip install --requirement $SOURCE_DIR/tools/perftests_ci/requirements.txt |
# can be controlled. Low significantly slows down the CPU but should reduce | ||
# variations due to frequency scaling. For more details see | ||
# https://slurm.schedmd.com/srun.html#OPT_cpu-freq. | ||
srun --cpu-freq=Low "${perftests_dir}/driver.py" -v -l "$logfile_tmp" perftest run --local True \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the CPU frequency will have to be requested through SLURM_CPU_FREQ_REQ
with the new setup.
Based on #1239
Fix #936
Many things to do still:
BUILD_DIR
are defined in the perftests script otherwise define them