Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move perftests reporting on PRs to alps #1255

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

aurianer
Copy link
Contributor

Based on #1239
Fix #936

Many things to do still:

  • Check if spack variables like BUILD_DIR are defined in the perftests script otherwise define them
  • Debug the pipeline once alps is up again

@aurianer aurianer self-assigned this Sep 27, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6fbce76) 18346 13778 75.10%
Head commit (b68104f) 18346 (+0) 13773 (-5) 75.07% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1255) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of initial comments. I understand this is still work in progress, so I'll have a closer look later.

Don't forget to remove the scripts from the .jenkins directory as well.

- export MIMALLOC_EAGER_COMMIT_DELAY=0
- python3 -m venv ~/venv_perftests
- source ~/venv_perftests/bin/activate
- python3 -m pip install $(cat $SOURCE_DIR/tools/perftests_ci/requirements.txt | grep -v \#)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work?

Suggested change
- python3 -m pip install $(cat $SOURCE_DIR/tools/perftests_ci/requirements.txt | grep -v \#)
- python3 -m pip install --requirement $SOURCE_DIR/tools/perftests_ci/requirements.txt

# can be controlled. Low significantly slows down the CPU but should reduce
# variations due to frequency scaling. For more details see
# https://slurm.schedmd.com/srun.html#OPT_cpu-freq.
srun --cpu-freq=Low "${perftests_dir}/driver.py" -v -l "$logfile_tmp" perftest run --local True \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CPU frequency will have to be requested through SLURM_CPU_FREQ_REQ with the new setup.

@aurianer aurianer changed the title [Very mich WIP] Move perftests reporting on PRs to alps [Very much WIP] Move perftests reporting on PRs to alps Sep 30, 2024
@msimberg msimberg changed the title [Very much WIP] Move perftests reporting on PRs to alps Move perftests reporting on PRs to alps Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Move the reporting of the performance tests on PRs to CSCS CI
2 participants