-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test and fix lifetimes of transform_mpi
values
#1321
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
93d6d6f
to
7eed53a
Compare
66127df
to
573e868
Compare
affc47d
to
38328c0
Compare
8f0b003
to
71901d1
Compare
Nice. Thanks. much cleaner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Add test for move only transform_mpi
…ransform_mpi let_value callable
…s sent from previous senders
0e6cac7
to
18b0162
Compare
Increasing the number of test repetitions for sanitizers/valgrind and more aggressively resetting operation states passed tests just fine on 0e6cac7. I'll go ahead and try to merge this. |
Test and fix lifetimes of `transform_mpi` values
The
transform_mpi
sender adaptor was not ensuring that the references passed to user-provided MPI callables are kept alive until the MPI request completes. This fixes that by adding an explicitlet_value
around the helper adaptors oftransform_mpi
. This PR also adds a number of new tests that trigger the issue if thelet_value
is not in place.