Skip to content

Commit

Permalink
fix(docs): Incorrect links to EF classes
Browse files Browse the repository at this point in the history
As the ecommerce framework has been moved into a standalone bundle, some links in the documentation which are still pointing to the main pimcore repository are broken
  • Loading branch information
GNi33 committed Nov 10, 2023
1 parent f49b521 commit ccc1376
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions doc/10_Working_with_Availabilities.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ Each product can have its own Availability System.

## Configuration of Availability Systems

A availability system is a class implementing `Pimcore\Bundle\EcommerceFrameworkBundle\AvailabilitySystem\AvailabilitySystemInterface` which
An availability system is a class implementing `Pimcore\Bundle\EcommerceFrameworkBundle\AvailabilitySystem\AvailabilitySystemInterface` which
is defined as service and registered with a name in the `pimcore_ecommerce_framework.availability_systems` configuration tree.

Currently the framework ships only with a [sample implementation](https://github.com/pimcore/pimcore/blob/11.x/bundles/EcommerceFrameworkBundle/AvailabilitySystem/AvailabilitySystem.php#L20)
Currently, the framework ships only with a [sample implementation](../src/AvailabilitySystem/AvailabilitySystem.php#L20)
which you can use as starting point.

There are 3 places where the configuration of Availability Systems takes place:
Expand Down
12 changes: 6 additions & 6 deletions doc/11_Cart_Manager.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
The Cart Manager is responsible for all aspects concerning carts and can manage multiple carts.
Important to know is, that in the E-Commerce Framework every user specific product collection is a cart. No matter
how it is called (cart, wish list, compare list, ...), all these product collections need the same base
functionality. Therefore all different product collections are carts with a specific name.
functionality. Therefore, all different product collections are carts with a specific name.


## Working with Carts
Expand Down Expand Up @@ -76,7 +76,7 @@ $subTotal = $cart->getPriceCalculator()->getSubTotal();
// iterates through all price modifications
foreach ($cart->getPriceCalculator()->getPriceModifications() as $name => $modification) {
// $name is the label of a modification
// $modification is a OnlineShop_Framework_IModificatedPrice
// $modification is an implementation of \Pimcore\Bundle\EcommerceFrameworkBundle\PriceSystem\ModificatedPriceInterface
}

// delivers sum including all price modifications
Expand Down Expand Up @@ -132,9 +132,9 @@ Following elements are configured:
by factory implementation
* **Price calculator factory service ID + options and modificators**: The price calculator is a framework for calculation
and modification (shipping costs, discounts, ...) of prices on cart level. Each modification is implemented in a
[`CartPriceModificatorInterface` class](https://github.com/pimcore/pimcore/blob/11.x/bundles/EcommerceFrameworkBundle/CartManager/CartPriceModificator/CartPriceModificatorInterface.php).
See [Shipping](https://github.com/pimcore/pimcore/blob/11.x/bundles/EcommerceFrameworkBundle/CartManager/CartPriceModificator/Shipping.php)
or [Discount](https://github.com/pimcore/pimcore/blob/11.x/bundles/EcommerceFrameworkBundle/CartManager/CartPriceModificator/Discount.php)
[`CartPriceModificatorInterface` class](../src/CartManager/CartPriceModificator/CartPriceModificatorInterface.php).
See [Shipping](../src/CartManager/CartPriceModificator/Shipping.php)
or [Discount](../src/CartManager/CartPriceModificator/Discount.php)
for examples.


Expand All @@ -151,7 +151,7 @@ Use this implementation when no user login is available and storing carts in the

* **Database-Cart** (class name `Pimcore\Bundle\EcommerceFrameworkBundle\CartManager\Cart`): This cart implementation
stores all cart information in the **database**. In this case, it is important that the currently logged in user is set
to the [E-Commerce Framework Environment](https://github.com/pimcore/pimcore/blob/11.x/bundles/EcommerceFrameworkBundle/EnvironmentInterface.php)
to the [E-Commerce Framework Environment](../src/EnvironmentInterface.php)
with the code snippet in the box below.
Use this implementation when user logins are available and the carts should be persisted beyond session lifetime.

Expand Down

0 comments on commit ccc1376

Please sign in to comment.