fix quotation for defaultmysql (#171)

* fix quotation for defaultmysql * fix quotation for defaultmysql * fix quotation for defaultmysql - remove typehints
pimcore · Mar 21, 2024 · f37c2d5 · f37c2d5
1 parent 95e2f7e
commit f37c2d5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/IndexService/ProductList/DefaultMysql.php b/src/IndexService/ProductList/DefaultMysql.php
@@ -618,9 +618,9 @@ protected function buildOrderBy(): ?string
 
                 if ($this->getVariantMode() == ProductListInterface::VARIANT_MODE_INCLUDE_PARENT_OBJECT) {
                     if (strtoupper($this->order) == 'DESC') {
-                        $orderByStringArray[] = 'max(`' . $key . '`) ' . $direction;
+                        $orderByStringArray[] = 'max(' . $this->resource->quoteIdentifier($key) . ') ' . $direction;
                     } else {
-                        $orderByStringArray[] = 'min(`' . $key . '`) ' . $direction;
+                        $orderByStringArray[] = 'min(' . $this->resource->quoteIdentifier($key) . ') ' . $direction;
                     }
                 } else {
                     $orderByStringArray[] = $key . ' ' . $direction;

diff --git a/src/IndexService/ProductList/DefaultMysql/Dao.php b/src/IndexService/ProductList/DefaultMysql/Dao.php
@@ -299,4 +299,9 @@ public function getLastRecordCount(): int
     {
         return $this->lastRecordCount;
     }
+
+    public function quoteIdentifier(string $value): string
+    {
+        return $this->db->quoteIdentifier($value);
+    }
 }