Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ecommerce][Bug] Empty mandatory fields does not prevent saving #99

Closed
NiklasBr opened this issue Feb 18, 2019 · 1 comment · Fixed by #123
Closed

[Ecommerce][Bug] Empty mandatory fields does not prevent saving #99

NiklasBr opened this issue Feb 18, 2019 · 1 comment · Fixed by #123
Assignees
Labels
Milestone

Comments

@NiklasBr
Copy link
Contributor

Bug Report

Expected behavior

Saving a Price Rule condition should not be possible when mandatory fields are empty.

Actual behavior

Saving works, no error messages or indications.

Steps to reproduce

Create a Price Rule condition with a mandatory field.
Save it.

Code example

If this field is left empty, the condition should not be saved, preferably an error message should be displayed.

{
	xtype: "numberfield",
	fieldLabel: "Minimum quantity",
	labelWidth: 200,
	mandatory: true,
	name: "qty",
	maxValue: 100000,
	value: data.qty,
	width: 600,
}
@NiklasBr NiklasBr changed the title [Ecommerce] Empty mandatory fields does not prevent saving [Ecommerce][Bug] Empty mandatory fields does not prevent saving Feb 18, 2019
@brusch brusch transferred this issue from pimcore/pimcore May 31, 2023
@dvesh3 dvesh3 added Bug and removed PR Welcome labels Aug 8, 2023
@kingjia90
Copy link
Contributor

Thank you for reporting and for your patience!
Do you have any chance to try this PR #123?

@kingjia90 kingjia90 added this to the 1.0.5 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants