Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add mandatory check on pricing rule conditions #123

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

kingjia90
Copy link
Contributor

Resolves #99

Misses the red asterix 🤔 not sure yet where can be added

Copy link
Contributor

@dvesh3 dvesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also prevent save based on mandatory check on server side?

src/Resources/public/js/pricing/config/item.js Outdated Show resolved Hide resolved
@kingjia90 kingjia90 requested a review from dvesh3 September 12, 2023 10:10
@kingjia90 kingjia90 removed their assignment Sep 12, 2023
@dvesh3 dvesh3 merged commit 9da9d4a into 1.x Sep 12, 2023
@dvesh3 dvesh3 deleted the mandatory-pricing-conditions branch September 12, 2023 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
@dvesh3
Copy link
Contributor

dvesh3 commented Sep 12, 2023

🍒 picked on 1.0 e7c0f80

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ecommerce][Bug] Empty mandatory fields does not prevent saving
2 participants