Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect links to source code in docs #138

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Fix incorrect links to source code in docs #138

merged 4 commits into from
Dec 15, 2023

Conversation

GNi33
Copy link
Contributor

@GNi33 GNi33 commented Nov 10, 2023

As the ecommerce framework has been moved into a standalone bundle, some links in the documentation which are still pointing to the main pimcore repository are broken

@dvesh3 dvesh3 added the Task label Nov 10, 2023
mcassier31
mcassier31 suggested changes Nov 10, 2023
View reviewed changes
Copy link

@mcassier31 mcassier31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your contribution!
Could you apply the following changes, please? :)

doc/09_Working_with_Prices/09_Calculate_with_Prices.md Outdated Show resolved Hide resolved
doc/09_Working_with_Prices/09_Calculate_with_Prices.md Outdated Show resolved Hide resolved
doc/10_Working_with_Availabilities.md Outdated Show resolved Hide resolved
@dvesh3 dvesh3 changed the base branch from 1.x to 1.0 November 10, 2023 13:59
@dvesh3 dvesh3 changed the base branch from 1.0 to 1.x November 10, 2023 13:59
@mcassier31
Copy link

Thanks for the update! Could you also rebase to 1.0 (bugfix) please?

@GNi33
Copy link
Contributor Author

GNi33 commented Nov 16, 2023 •
edited
Loading

I see, would I need to change the absolute links from /pimcore/ecommerce-framework-bundle/blob/1.x/ to /pimcore/ecommerce-framework-bundle/blob/1.0/ in that case?

@mcassier31
Copy link

Hi! As 1.0 will be deleted after the next minor release, keeping the links pointing to 1.x is better. In that way, we will not need to update them again for 1.1 :)

@kingjia90 kingjia90 added this to the 1.0.9 milestone Dec 15, 2023
@kingjia90 kingjia90 self-assigned this Dec 15, 2023
@kingjia90 kingjia90 changed the base branch from 1.x to 1.0 December 15, 2023 10:28
GNi33 added 4 commits December 15, 2023 11:30
@GNi33 @kingjia90
fix(docs): Incorrect links to EF classes
5851cfc 
As the ecommerce framework has been moved into a standalone bundle, some links in the documentation which are still pointing to the main pimcore repository are broken
@GNi33 @kingjia90
fix(docs): Incorrect links to EF classes
121dc9c 
As the ecommerce framework has been moved into a standalone bundle, some links in the documentation which are still pointing to the main pimcore repository are broken
@GNi33 @kingjia90
fix(docs): Incorrect links to EF classes
3aba5bc 
Fix a few remaining links and replace all relative links with absolute links to the repository
@GNi33 @kingjia90
fix(docs): Incorrect links to EF classes
8e18119 
Changes, remove erroneously inserted lines
@kingjia90 kingjia90 changed the base branch from 1.0 to 1.x December 15, 2023 10:31
@kingjia90 kingjia90 changed the base branch from 1.x to 1.0 December 15, 2023 10:31
@kingjia90 kingjia90 merged commit 9811190 into pimcore:1.0 Dec 15, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcassier31 mcassier31 mcassier31 requested changes

Assignees

@kingjia90 kingjia90

@mcassier31 mcassier31

Labels
Task
Projects
None yet
Milestone
1.0.9
Development

Successfully merging this pull request may close these issues.
4 participants
@GNi33 @mcassier31 @dvesh3 @kingjia90