Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exception on empty configration prefix #142

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

andreas-gruenwald
Copy link
Contributor

If no prefix is given for a voucher series of type "pattern", then currently an exception is thrown.
This PR generates voucher series with empty prefix correctly.

Copy link

github-actions bot commented Nov 27, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@andreas-gruenwald
Copy link
Contributor Author

andreas-gruenwald commented Nov 27, 2023

I have read the CLA Document and I hereby sign the CLA.

@andreas-gruenwald
Copy link
Contributor Author

recheck

Force cla reverification.
@andreas-gruenwald
Copy link
Contributor Author

@fashxp Would be grateful if you can accept this one.

@fashxp fashxp added the Bug label Dec 21, 2023
@fashxp fashxp added this to the 1.0.9 milestone Dec 21, 2023
@fashxp fashxp merged commit 0896260 into pimcore:1.x Dec 21, 2023
7 checks passed
@fashxp
Copy link
Member

fashxp commented Dec 21, 2023

thx very much

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants