Add setCustomProperties method to CartItemInterface #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use $params in Cart::addItem
…use $params in Cart::addItem
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…chinger/ecommerce-framework-bundle into add-custom-properties-to-cart-item
…d $params variable
|
Hi @fashxp, just wanted to check back regarding #143 (comment). Do you suggest to add a new field Thanks, |
|
@dblaichinger sorry for not coming back earlier, I missed that comment :( yes, I was thinking of saving this additional data automatically. Not sure, what is necessary for that all though out of my head ... probably depends on the cart implementation, as the db cart will need some additional database table and some strategy to save this data (e.g. as json or something similar). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In order to avoid
BC-BREAKin #143, the extension ofCartItemInterfacewas removed there. See: #143 (comment)This pull request will extend the
CartItemInterfaceagain, as the methodsetCustomPropertiesshould be defined there.Please add label
BC-BREAKhere and consider it when creating next major release.Thank you!