[bugfix] Legacy data with null-values clash with the stronger typing #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes legacy data could trigger an exception because of null-values.
jdreesen
reviewed
Jan 17, 2024
| @@ -120,7 +120,7 @@ public function setValue(string $key, mixed $value, bool $ignoreEmptyValues = fa | |||
| return $this; | |||
| } | |||
| } | |||
| $this->$method($value); | |||
| $this->$method($value ?? ''); | |||
There was a problem hiding this comment.
But we can't be sure it's always of type string, right?
There was a problem hiding this comment.
Will look into that.
There was a problem hiding this comment.
It seems that setactions
setconditionwouldn't work with strings
There was a problem hiding this comment.
@Daniel-Ateles any updates? 👍
There was a problem hiding this comment.
@Daniel-Ateles friendly reminder ⏰ 🍭
There was a problem hiding this comment.
@Corepex I guess this PR solved faulty DB-data in my case and should have been solved by removing the faulty rules from the db table instead. This PR can be closed/removed.
|
Closed #153 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes legacy data could trigger an exception because of null-values.