Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix voucher token max usage limit #157

Merged

Conversation

dolmit-tanel-paaro
Copy link
Contributor

Before the change, this situation was possible:
image

The expected behavior is that you can't apply a voucher token that has reached it's limit.
The actual behavior is that the voucher token's limit is usages + 1.

Copy link

github-actions bot commented Jan 29, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@blankse
Copy link
Contributor

blankse commented Jan 29, 2024

@dolmit-tanel-paaro The target branch should be 1.0 because it is a bug fix.

@dolmit-tanel-paaro dolmit-tanel-paaro changed the base branch from 1.x to 1.0 January 29, 2024 13:34
@dolmit-tanel-paaro dolmit-tanel-paaro changed the base branch from 1.0 to 1.x January 29, 2024 13:36
@dolmit-tanel-paaro dolmit-tanel-paaro changed the base branch from 1.x to 1.0 January 29, 2024 13:38
@dolmit-tanel-paaro dolmit-tanel-paaro force-pushed the fix-voucher-token-max-usage-limit branch from 32a7a43 to 8ab92e4 Compare January 29, 2024 13:39
@dolmit-tanel-paaro
Copy link
Contributor Author

@dolmit-tanel-paaro The target branch should be 1.0 because it is a bug fix.

Thanks, rebased.

@dolmit-tanel-paaro
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@dolmit-tanel-paaro
Copy link
Contributor Author

recheck

@dolmit-tanel-paaro dolmit-tanel-paaro changed the title Fix voucher token max usage limit [bugfix] Fix voucher token max usage limit Jan 29, 2024
@Corepex Corepex closed this Mar 29, 2024
@Corepex Corepex reopened this Mar 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
@markus-moser markus-moser added this to the 1.0.12 milestone Mar 29, 2024
@markus-moser markus-moser merged commit 2ace7ec into pimcore:1.0 Mar 29, 2024
7 of 8 checks passed
@markus-moser
Copy link
Contributor

Thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants