Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast value to string for selectCategory #169

Closed
wants to merge 1 commit into from

Conversation

AlternateIf
Copy link
Contributor

trim might cause an error in case of an actual id (int) being given instead of a string. cast to string to avoid this (see https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/FilterService/FilterType/ElasticSearch/SelectCategory.php#L73)

trim might cause an error in case of an actual id (int) being given
Copy link

github-actions bot commented Mar 12, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@AlternateIf
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@fashxp
Copy link
Member

fashxp commented Mar 12, 2024

Thx very much, please rebase to 1.0

@AlternateIf
Copy link
Contributor Author

AlternateIf commented Mar 13, 2024

Thx very much, please rebase to 1.0

@fashxp so adding the original repo as upstream and doing a rebase on the 1.0 branch (git rebase upstream/1.0) right?

@blankse
Copy link
Contributor

blankse commented Mar 13, 2024

@AlternateIf You need to use the --onto option. Otherwise you still have the commits from 1.x in the branch.
git rebase --onto origin/1.0 origin/1.x
Than you have to use the force push:
git push --force

@AlternateIf
Copy link
Contributor Author

just saw that this was already resolved in 1.0.11 by 6ebfd3e

i am going to close this

@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants