Added additional env params #213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we include RabbitMQ as well? |
|
@brusch added |
jdreesen
reviewed
Dec 2, 2024
| @@ -52,6 +52,13 @@ services: | |||
| PIMCORE_INSTALL_MYSQL_PORT: 3306 | |||
| PIMCORE_INSTALL_MYSQL_HOST_SOCKET: db | |||
| PIMCORE_INSTALL_MYSQL_DATABASE: pimcore | |||
| GOTENBERG_IP: "1.2.3.4" | |||
| GOTENBERG_PORT: "3000" | |||
| PLATFORM_PROJECT_ENTROPY: "1234567890" | |||
There was a problem hiding this comment.
What is this? Looks like it should be changed by the user to a random value. Maybe an explaining comment would be helpful.
brusch
requested changes
Dec 3, 2024
| REDIS_HOST: "redis" | ||
| REDIS_PORT: "6379" | ||
| PIMCORE_TOKEN: "1234567890" | ||
| RABBITMQ_URL: "amqp://user:pass@rabbitmq:1234" |
There was a problem hiding this comment.
Suggested change
| RABBITMQ_URL: "amqp://user:pass@rabbitmq:1234" | |
| RABBITMQ_URL: "amqp://rabbitmq:5672" |
Here we should use the proper port, otherwise it won't work out of the box.
| @@ -52,6 +52,13 @@ services: | |||
| PIMCORE_INSTALL_MYSQL_PORT: 3306 | |||
| PIMCORE_INSTALL_MYSQL_HOST_SOCKET: db | |||
| PIMCORE_INSTALL_MYSQL_DATABASE: pimcore | |||
| GOTENBERG_IP: "1.2.3.4" | |||
There was a problem hiding this comment.
Suggested change
| GOTENBERG_IP: "1.2.3.4" | |
| GOTENBERG_IP: "gotenberg" |
Same here, we need to use the proper config, otherwise Gotenberg won't work when having the config in place using the env vars.
Maybe we should also think about the naming, e.g. GOTENBERG_HOST is more specific? 🤔 We'd need to change this in pimcore/paas then as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.