Merge remote-tracking branch 'origin/1.1' into 1.x

pimcore · Mar 12, 2024 · f4c14bc · f4c14bc
2 parents fb647d0 + ce7c018
commit f4c14bc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/public/js/document/printpages/pdf_preview.js b/public/js/document/printpages/pdf_preview.js
@@ -92,7 +92,7 @@ pimcore.document.printpages.pdfpreview = Class.create({
                 style: "float: right; margin-top: 10px",
                 handler: function () {
                     var date = new Date();
-                    var url = Routing.generate('pimcore_bundle_document_printpage_pdfdownload', {id: this.page.id, download: 1, time: date.getTime()});
+                    var url = Routing.generate('pimcore_bundle_web2print_document_printpage_pdfdownload', {id: this.page.id, download: 1, time: date.getTime()});
                     pimcore.helpers.download(url);
                 }.bind(this)
             });

diff --git a/src/Processor/Chromium.php b/src/Processor/Chromium.php
@@ -120,8 +120,9 @@ public function getPdfFromString(string $html, array $params = [], bool $returnF
             ]);
         }
 
+        $page = $browser->createPage();
+
         try {
-            $page = $browser->createPage();
             $page->setHtml($html, 5000);
 
             $pdf = $page->pdf($params);
@@ -136,7 +137,7 @@ public function getPdfFromString(string $html, array $params = [], bool $returnF
             Logger::debug('Could not create pdf with chromium: '. print_r($e, true));
             $output = (string) $e;
         } finally {
-            $browser->close();
+            $page->close();
         }
 
         return $output;