Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better version sorting #57

Merged
merged 5 commits into from
Dec 9, 2020
Merged

Better version sorting #57

merged 5 commits into from
Dec 9, 2020

Conversation

Roy-Orbison
Copy link
Contributor

@Roy-Orbison Roy-Orbison commented Sep 10, 2020

Have remote list sorted correctly by default for better readability latest version selection (in case -rc* versions are used).

Previous output of ubuntu-mainline-kernel -r v5.8. --rc:

Downloading index from kernel.ubuntu.com
v5.8.0-rc1      v5.8.0-rc2      v5.8.0-rc3      v5.8.0-rc4      v5.8.0-rc5      v5.8.0-rc6      v5.8.0-rc7      v5.8.1
v5.8.2          v5.8.3          v5.8.4          v5.8.5          v5.8.6          v5.8.7          v5.8.8          v5.8.9
v5.8.10         v5.8.0

Updated output:

Downloading index from kernel.ubuntu.com
v5.8.0-rc1      v5.8.0-rc2      v5.8.0-rc3      v5.8.0-rc4      v5.8.0-rc5      v5.8.0-rc6      v5.8.0-rc7      v5.8.0
v5.8.1          v5.8.2          v5.8.3          v5.8.4          v5.8.5          v5.8.6          v5.8.7          v5.8.8
v5.8.9          v5.8.10

Have remote list sorted correctly by default for better readability latest version selection (in case `-rc*` versions are used).
Take advantage of Debian's convention of using ~ for pre-release suffixes.
ubuntu-mainline-kernel.sh Outdated Show resolved Hide resolved
@Roy-Orbison
Copy link
Contributor Author

@pimlie The Perl dependency is gone, is there something else?

Copy link
Owner

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on parsing the versions here, much cleaner this way!

Have two small remarks, mainly to avoid confusion in the future.

Btw, I guess this pr would resolve this issue too? #39

ubuntu-mainline-kernel.sh Outdated Show resolved Hide resolved
ubuntu-mainline-kernel.sh Show resolved Hide resolved
@Roy-Orbison
Copy link
Contributor Author

I don't know if this will completely resolve #39, it may be affected by #58.

@pimlie pimlie merged commit bdb32e3 into pimlie:master Dec 9, 2020
@pimlie
Copy link
Owner

pimlie commented Dec 9, 2020

Thanks for the changes!

@Roy-Orbison Roy-Orbison deleted the patch-1 branch December 9, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants