Reduce blocking time and response times for public interface when gar…

…bage collecting in the process store Adapt to observation from production: The part enumerating the file paths can take the most time. To reduce response times on the public interface, move that part out of the locked region.
pine-vm · Jan 30, 2021 · 783f207 · 783f207
1 parent b827411
commit 783f207
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/implement/PersistentProcess/PersistentProcess.WebHost/Program.cs b/implement/PersistentProcess/PersistentProcess.WebHost/Program.cs
@@ -2,6 +2,6 @@ namespace Kalmit.PersistentProcess.WebHost
 {
     public class Program
     {
-        static public string AppVersionId => "2021-01-29";
+        static public string AppVersionId => "2021-01-30";
     }
 }
diff --git a/implement/PersistentProcess/PersistentProcess.WebHost/StartupAdminInterface.cs b/implement/PersistentProcess/PersistentProcess.WebHost/StartupAdminInterface.cs
@@ -533,8 +533,12 @@ TruncateProcessHistoryReport truncateProcessHistory(TimeSpan productionBlockDura
 
                         var totalStopwatch = System.Diagnostics.Stopwatch.StartNew();
 
+                        var filePathsInProcessStore = processStoreFileStore.ListFilesInDirectory(ImmutableList<string>.Empty);
+
                         lock (avoidConcurrencyLock)
                         {
+                            var lockStopwatch = System.Diagnostics.Stopwatch.StartNew();
+
                             var storeReductionStopwatch = System.Diagnostics.Stopwatch.StartNew();
 
                             var storeReductionReport =
@@ -556,12 +560,12 @@ TruncateProcessHistoryReport truncateProcessHistory(TimeSpan productionBlockDura
 
                             int deletedFilesCount = 0;
 
-                            foreach (var filePath in processStoreFileStore.ListFilesInDirectory(ImmutableList<string>.Empty))
+                            foreach (var filePath in filePathsInProcessStore)
                             {
                                 if (filesForRestore.Contains(filePath))
                                     continue;
 
-                                if (productionBlockDurationLimit < totalStopwatch.Elapsed)
+                                if (productionBlockDurationLimit < lockStopwatch.Elapsed)
                                     break;
 
                                 processStoreFileStore.DeleteFile(filePath);
@@ -578,6 +582,7 @@ TruncateProcessHistoryReport truncateProcessHistory(TimeSpan productionBlockDura
                                 storeReductionReport = storeReductionReport,
                                 getFilesForRestoreTimeSpentMilli = (int)getFilesForRestoreStopwatch.ElapsedMilliseconds,
                                 deleteFilesTimeSpentMilli = (int)deleteFilesStopwatch.ElapsedMilliseconds,
+                                lockedTimeSpentMilli = (int)lockStopwatch.ElapsedMilliseconds,
                                 totalTimeSpentMilli = (int)totalStopwatch.ElapsedMilliseconds,
                             };
                         }
@@ -738,6 +743,8 @@ public class TruncateProcessHistoryReport
 
         public int deletedFilesCount;
 
+        public int lockedTimeSpentMilli;
+
         public int totalTimeSpentMilli;
 
         public int storeReductionTimeSpentMilli;

diff --git a/implement/elm-fullstack/elm-fullstack.csproj b/implement/elm-fullstack/elm-fullstack.csproj
@@ -5,8 +5,8 @@
     <TargetFramework>netcoreapp3.1</TargetFramework>
     <RootNamespace>elm_fullstack</RootNamespace>
     <AssemblyName>elm-fullstack</AssemblyName>
-    <AssemblyVersion>2021.0129.0.0</AssemblyVersion>
-    <FileVersion>2021.0129.0.0</FileVersion>
+    <AssemblyVersion>2021.0130.0.0</AssemblyVersion>
+    <FileVersion>2021.0130.0.0</FileVersion>
   </PropertyGroup>
 
   <PropertyGroup>