Improve error messages in Elm Interactive tests

+ Print the submission for the failed step. + Remove duplicate names from the report of available names.
pine-vm · Nov 6, 2020 · e3a483d · e3a483d
1 parent 0adfc10
commit e3a483d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/implement/elm-fullstack/ElmEngine/evaluate-elm-program/src/Pine.elm b/implement/elm-fullstack/ElmEngine/evaluate-elm-program/src/Pine.elm
@@ -2,6 +2,7 @@ module Pine exposing (..)
 
 import BigInt
 import Result.Extra
+import Set
 
 
 type PineExpression
@@ -132,12 +133,17 @@ lookUpNameInContext name context =
 
         nameFirstElement :: nameRemainingElements ->
             let
-                availableNames =
+                availableNamedValues =
                     context.commonModel
                         |> List.filterMap pineNamedValueFromValue
 
+                availableNames =
+                    availableNamedValues
+                        |> List.map Tuple.first
+                        |> Set.fromList
+
                 maybeMatchingValue =
-                    availableNames
+                    availableNamedValues
                         |> List.filter (Tuple.first >> (==) nameFirstElement)
                         |> List.head
                         |> Maybe.map Tuple.second
@@ -148,9 +154,9 @@ lookUpNameInContext name context =
                         ("Did not find '"
                             ++ nameFirstElement
                             ++ "'. "
-                            ++ (availableNames |> List.length |> String.fromInt)
+                            ++ (availableNames |> Set.size |> String.fromInt)
                             ++ " names available: "
-                            ++ (availableNames |> List.map Tuple.first |> String.join ", ")
+                            ++ (availableNames |> Set.toList |> String.join ", ")
                         )
 
                 Just firstNameValue ->

diff --git a/implement/test-elm-fullstack/TestElmInteractive.cs b/implement/test-elm-fullstack/TestElmInteractive.cs
@@ -60,9 +60,11 @@ public void TestElmInteractiveScenarios()
                         {
                             var stepName = Path.GetFileName(stepDirectory);
 
+                            string submission = null;
+
                             try
                             {
-                                var submission =
+                                submission =
                                     File.ReadAllText(Path.Combine(stepDirectory, "submission"), System.Text.Encoding.UTF8);
 
                                 var evalResult =
@@ -74,15 +76,17 @@ public void TestElmInteractiveScenarios()
                                 {
                                     var expectedValue = File.ReadAllText(expectedValueFilePath, System.Text.Encoding.UTF8);
 
+                                    Assert.IsNull(evalResult.Err, "Submission result has error: " + evalResult.Err);
+
                                     Assert.AreEqual(
                                         expectedValue,
                                         evalResult.Ok?.valueAsElmExpressionText,
-                                        "Value from evaluation matches expected value in scenario '" + scenarioName + "'");
+                                        "Value from evaluation does not match expected value.");
                                 }
                             }
                             catch (Exception e)
                             {
-                                throw new Exception("Failed step '" + stepName + "' with exception.", e);
+                                throw new Exception("Failed step '" + stepName + "' with exception.\nSubmission in this step:\n" + submission, e);
                             }
                         }
                     }