Add missing defaults #46

acatav · 2023-09-14T14:22:51Z

Problem

We missed some defaults in several places

Add defaults

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Infrastructure change (CI configs, etc)
Non-code change (docs, etc)
None of the above: (explain here)

Same tests apply

To be more consistent

igiloh-pinecone force-pushed the config_file branch from 108bfea to c8cf3ad Compare September 27, 2023 14:23

igiloh-pinecone changed the base branch from config_file to old_config_file September 27, 2023 14:25

acatav added 5 commits September 27, 2023 18:08

markdown defaults in config

d8c16c7

kb encoder and chunker defaults in create_with_new_index

2b2b503

chatgpt model default

47e6bfd

use default llm in app

220cb3f

add defualt LLM to chat engine

d9ac6db

igiloh-pinecone force-pushed the add-missing-defaults branch from 690f813 to d9ac6db Compare September 27, 2023 15:09

igiloh-pinecone changed the base branch from old_config_file to config_file September 27, 2023 15:09

igiloh-pinecone added 2 commits September 27, 2023 18:13

[config] Fixed a few more default params

421119f

To be more consistent

[test] Bug fix after defaults change

c45f9b9

igiloh-pinecone merged commit b34c909 into config_file Sep 28, 2023
1 check passed

igiloh-pinecone deleted the add-missing-defaults branch September 28, 2023 07:58