Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

DF data validation cli #74

Merged
merged 4 commits into from
Oct 18, 2023
Merged

DF data validation cli #74

merged 4 commits into from
Oct 18, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Oct 16, 2023

Problem

Data sample for validation is currently displayed as json and not df

Solution

Convert the first 5 lines to dataframe and display it

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

manual test

@acatav acatav changed the base branch from dev to special-tokens-as-natural-text October 16, 2023 09:12
resin_cli/cli.py Outdated Show resolved Hide resolved
Base automatically changed from special-tokens-as-natural-text to dev October 17, 2023 12:42
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acatav acatav merged commit 1936fc6 into dev Oct 18, 2023
9 checks passed
@acatav acatav deleted the df-data-validation-cli branch October 18, 2023 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants