This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It doesn't make too much sense to require the
index_params
argument in the constructor. In interactive usage - this param should be passed directly to thecreate_resin_index()
Solution
method. I had to complicate the code of
from_config()
a bit - but it makes the usage pattern of KnowledgeBase much more explicit and readable.Type of Change
Test Plan
Currently not covered. Will add test case separately.