Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Improve randomness of stub encoder #79

Closed
wants to merge 2 commits into from
Closed

Improve randomness of stub encoder #79

wants to merge 2 commits into from

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Oct 17, 2023

Problem

For low dimension we encounter very close vectors from our stub encoder.

Solution

Improve randomness of stub encoder output by setting each dimension value sign randomly.
This fix reduce the likelihood for collisions by 2 ** -i

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

the change is part of the tests infra

@acatav acatav closed this Oct 17, 2023
@acatav acatav deleted the fix-stub-encoder branch October 30, 2023 08:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant