This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 122
Use BOW values projected to dense as stub embeddings for test #80
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
152b279
use BOW values projected to dense as stub embeddings for test
acatav 1ba7a36
add scipy to dev dependencies
acatav 5e13407
use float32
acatav fa07dcd
Merge branch 'dev' into stub-bow-embedding
acatav beadc9f
Merge branch 'dev' into stub-bow-embedding
acatav a14df18
reduce default vocab size
acatav 025cfb6
Merge remote-tracking branch 'origin/stub-bow-embedding' into stub-bo…
acatav c37ec5b
Merge branch 'dev' into stub-bow-embedding
acatav 6bda91d
remove the need in random matrix
acatav fe8c59f
Merge remote-tracking branch 'origin/stub-bow-embedding' into stub-bo…
acatav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait - isn't that a HUGE shape??
It's a dense matrix, isn't it? Won't it take a lot of memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the need in actually holding this matrix, for the default dimensions it's few MB but for output dim 1536 it can become larger than we would like. Anyway, we not even holding a matrix any more