Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

increase upsert from CLI batch size default to 50 #96

Merged
merged 2 commits into from
Oct 24, 2023
Merged

increase upsert from CLI batch size default to 50 #96

merged 2 commits into from
Oct 24, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Oct 24, 2023

Problem

Default batch size in upsert from CLI is too small

Solution

Increase to 50

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • default param change

Test Plan

same tests we have

igiloh-pinecone
igiloh-pinecone approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acatav acatav enabled auto-merge October 24, 2023 15:31
@acatav acatav merged commit 5d1874a into dev Oct 24, 2023
10 checks passed
@acatav acatav deleted the increase-cli-upsert-batch-size branch October 24, 2023 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igiloh-pinecone igiloh-pinecone igiloh-pinecone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acatav @igiloh-pinecone