-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dxf: systable and scheduler change for modify task at runtime #57557
Conversation
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57557 +/- ##
================================================
+ Coverage 72.8292% 74.6500% +1.8207%
================================================
Files 1676 1692 +16
Lines 463753 464517 +764
================================================
+ Hits 337748 346762 +9014
+ Misses 105139 96324 -8815
- Partials 20866 21431 +565
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
@@ -1375,6 +1381,7 @@ var ( | |||
upgradeToVer216, | |||
upgradeToVer217, | |||
upgradeToVer218, | |||
upgradeToVer239, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consult that why the version is changed from 218 to 239, not 219?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see the comment
// ...
// [version219, version238] is the version range reserved for patches of 8.5.x
// ...
// next version should start with 239
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
/approve for disttask pkg |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, fzzf678, joccau, yudongusa, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #57497
Problem Summary:
What changed and how does it work?
Add a new task state
modifying
and add a new fieldmodify_params
which holds parameters about current modification. the system table change part has verified with PM @Frank945946Add some basic interface in storage for modify and add a empty impl in scheduler
Check List
Tests
upgrade from 8.1, success, task and history table matches
bootstrap with master, success, task and history table matches
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.