Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dxf: systable and scheduler change for modify task at runtime #57557

Merged
merged 10 commits into from
Nov 25, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Nov 20, 2024

What problem does this PR solve?

Issue Number: ref #57497

Problem Summary:

What changed and how does it work?

Add a new task state modifying and add a new field modify_params which holds parameters about current modification. the system table change part has verified with PM @Frank945946
Add some basic interface in storage for modify and add a empty impl in scheduler

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

upgrade from 8.1, success, task and history table matches
bootstrap with master, success, task and history table matches

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2024
Copy link

tiprow bot commented Nov 20, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 30 lines in your changes missing coverage. Please review.

Project coverage is 74.6500%. Comparing base (14ff938) to head (db59aaa).
Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57557        +/-   ##
================================================
+ Coverage   72.8292%   74.6500%   +1.8207%     
================================================
  Files          1676       1692        +16     
  Lines        463753     464517       +764     
================================================
+ Hits         337748     346762      +9014     
+ Misses       105139      96324      -8815     
- Partials      20866      21431       +565     
Flag Coverage Δ
integration 46.6196% <3.7037%> (?)
unit 72.3708% <67.0731%> (+0.1464%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 61.1456% <ø> (+15.7078%) ⬆️
---- 🚨 Try these New Features:

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Nov 20, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter changed the title dxf: systable and scheduler change for modify task at runtime [WIP]dxf: systable and scheduler change for modify task at runtime Nov 21, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2024
@D3Hunter D3Hunter changed the title [WIP]dxf: systable and scheduler change for modify task at runtime dxf: systable and scheduler change for modify task at runtime Nov 21, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Nov 21, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 25, 2024
@@ -1375,6 +1381,7 @@ var (
upgradeToVer216,
upgradeToVer217,
upgradeToVer218,
upgradeToVer239,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consult that why the version is changed from 218 to 239, not 219?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comment

	// ...
	// [version219, version238] is the version range reserved for patches of 8.5.x
	// ...

	// next version should start with 239

Copy link
Contributor

@fzzf678 fzzf678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 25, 2024
Copy link

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-25 02:58:17.644615751 +0000 UTC m=+432485.264270252: ☑️ agreed by joccau.
  • 2024-11-25 05:01:05.785209065 +0000 UTC m=+439853.404863580: ☑️ agreed by fzzf678.

@D3Hunter
Copy link
Contributor Author

/approve

for disttask pkg

Copy link

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, fzzf678, joccau, yudongusa, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit 9ff83eb into pingcap:master Nov 25, 2024
29 checks passed
@D3Hunter D3Hunter deleted the dxf-modify-task branch November 25, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants