Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka(ticdc): sarama do not retry if produce message failed to prevent out of order (#11870) #11961

Open
wants to merge 3 commits into
base: release-8.5
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11870

What problem does this PR solve?

Issue Number: close #11935

What is changed and how it works?

  • config.Net.MaxOpenRequest is set to 1
  • config.Producer.Retry.Max is set to 0, to disable the internal retry mechanism

The root cause of the out-of-order message problem comes from the sarama internal bug, cannot be easily fixed, this is a workaround solution, by set the retry.max to 0, to disable the retry.

Check List

Tests

  • Unit test
  • Integration test

This is tested by an internal E2E test, which inject network partition between the random cdc node and random kafka server. Before this PR, the test case cannot be passed, and we found out-of-order message by reading consumer log, after this PR it can be passed, and no out-of-order message.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

fix the sarama retry caused out-of-order message by set retry count to 0 as a workaround

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign holys for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@e7de6be). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 59.7194% <0.0000%> (?)
dm 50.0539% <0.0000%> (?)
engine 53.2223% <0.0000%> (?)
Flag Coverage Δ
unit 55.1991% <55.5555%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.5     #11961   +/-   ##
================================================
  Coverage               ?   55.1991%           
================================================
  Files                  ?       1002           
  Lines                  ?     136542           
  Branches               ?          0           
================================================
  Hits                   ?      75370           
  Misses                 ?      55662           
  Partials               ?       5510           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants