kafka(ticdc): sarama do not retry if produce message failed to prevent out of order (#11870) #11961
+9
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #11870
What problem does this PR solve?
Issue Number: close #11935
What is changed and how it works?
config.Net.MaxOpenRequest
is set to 1config.Producer.Retry.Max
is set to 0, to disable the internal retry mechanismThe root cause of the out-of-order message problem comes from the sarama internal bug, cannot be easily fixed, this is a workaround solution, by set the
retry.max
to 0, to disable the retry.Check List
Tests
This is tested by an internal E2E test, which inject network partition between the random cdc node and random kafka server. Before this PR, the test case cannot be passed, and we found out-of-order message by reading consumer log, after this PR it can be passed, and no out-of-order message.
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note