Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update packages #1090
chore: update packages #1090
Changes from all commits
216d4a4
b4c0cc5
2324188
9fd3a47
030d2bd
4e324b2
75a5f62
df3e30d
da0b7b7
c87c658
e95f78e
95da831
8c29d77
887d9bd
8eeff81
b1f3731
46047f8
369663f
830b40c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider replacing
any
type assertions with proper type definitions.The current use of
as any
bypasses TypeScript's type checking system. This could lead to runtime errors if the child component doesn't have the expected properties.Consider defining proper interfaces:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are cause we have some type mismatches in react 18 and 19. i'm hoping we can bump the docs to R19 soon, so for now these casts will work fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliusmarminge, understood. Thank you for explaining. We'll proceed with the casts as a temporary solution until the upgrade to React 19.
✏️ Learnings added