Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log xhr error #1121

Closed
wants to merge 2 commits into from
Closed

chore: log xhr error #1121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ba0eeb
log
juliusmarminge Jan 4, 2025
41b9159
more
juliusmarminge Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/uploadthing/src/_internal/upload-browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ const uploadWithProgress = (

// Is there a case when the client would throw and
// ingest server not knowing about it? idts?
xhr.addEventListener("error", () => {
xhr.addEventListener("error", (err) => {
// eslint-disable-next-line no-console
console.log("XHR error", err, xhr);
resume(
new UploadThingError({
code: "UPLOAD_FAILED",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this error also include the cause?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR can be closed since there's no way for JS to actaully get the error here: https://issues.chromium.org/issues/40170162#comment6

Expand Down
Loading