chore: update cdn url #1123
chore: update cdn url #1123
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
WalkthroughThis pull request involves a comprehensive update to the URL structure for file handling across multiple components of the application. The primary change is replacing the hostname from "utfs.io" to a new format using "<APP_ID>.ufs.sh" for file URLs. This modification affects configuration files, documentation, test suites, and example applications, ensuring consistent URL generation and file access across the project. Changes
Suggested reviewers
Possibly related PRs
Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
📦 Bundle size comparison
|
More templates
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (5)
docs/next.config.js (1)
22-23: Consider using environment variables for the hostnameThe hostname is currently hardcoded with a specific app ID. Consider using environment variables to make the configuration more portable across different environments:
- hostname: "s40vlb3kca.ufs.sh", + hostname: `${process.env.NEXT_PUBLIC_UPLOADTHING_APP_ID}.ufs.sh`,packages/react/test/upload-dropzone.browser.test.tsx (1)
46-46: Use a consistent test constant for the app IDThe hardcoded "app-1" in the URL should be replaced with a test constant to maintain consistency and make tests more maintainable:
- return HttpResponse.json({ url: "https://app-1.ufs.sh/f/" + params.key }); + return HttpResponse.json({ url: `https://${TEST_APP_ID}.ufs.sh/f/${params.key}` });Consider adding this constant at the top of the file:
const TEST_APP_ID = "app-1";packages/uploadthing/test/sdk.live.test.ts (1)
Line range hint
270-270: Update the commented URL to use the new format.Even though this is commented code, it should be updated to use the new URL format for consistency.
- // url: "https://app-1.ufs.sh/f/abc-123.txt", + // url: `https://${testToken.decoded.appId}.${UFS_HOST}/f/abc-123.txt`,docs/src/app/(docs)/working-with-files/page.mdx (2)
35-35: Fix grammatical error in setup instructions.Change "setup" to "set up" when used as a verb phrase.
-to setup image optimization allow filtering in Next.js that only allows +to set up image optimization allow filtering in Next.js that only allows🧰 Tools
🪛 LanguageTool
[uncategorized] ~35-~35: Possible missing preposition found.
Context: ...mple of how to setup image optimization allow filtering in Next.js that only allows o...(AI_HYDRA_LEO_MISSING_TO)
Line range hint
15-46: Consider simplifying the file access documentation.Based on previous feedback, this section could be more concise by focusing on three key points:
- Don't use storage URLs
- Use the correct URL format:
https://<appid>.ufs.sh/f/<fileKey | customId>- Next.js configuration example
🧰 Tools
🪛 LanguageTool
[uncategorized] ~35-~35: Possible missing preposition found.
Context: ...mple of how to setup image optimization allow filtering in Next.js that only allows o...(AI_HYDRA_LEO_MISSING_TO)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
docs/next.config.js(1 hunks)docs/src/app/(api)/api/og/blog/route.tsx(1 hunks)docs/src/app/(api)/api/og/docs/route.tsx(1 hunks)docs/src/app/(docs)/concepts/regions-acl/page.mdx(1 hunks)docs/src/app/(docs)/working-with-files/page.mdx(2 hunks)examples/minimal-expo/.env.example(1 hunks)examples/minimal-expo/app/f/[key].tsx(1 hunks)packages/react/test/upload-button.browser.test.tsx(1 hunks)packages/react/test/upload-dropzone.browser.test.tsx(1 hunks)packages/uploadthing/test/__test-helpers.ts(4 hunks)packages/uploadthing/test/client.browser.test.ts(4 hunks)packages/uploadthing/test/request-handler.test.ts(5 hunks)packages/uploadthing/test/sdk.live.test.ts(8 hunks)packages/uploadthing/test/sdk.test.ts(6 hunks)playground/middleware.ts(2 hunks)
✅ Files skipped from review due to trivial changes (3)
- docs/src/app/(api)/api/og/docs/route.tsx
- packages/react/test/upload-button.browser.test.tsx
- docs/src/app/(api)/api/og/blog/route.tsx
🧰 Additional context used
🪛 GitHub Actions: CI
packages/uploadthing/test/sdk.live.test.ts
[error] 59-59: Test 'should upload a file' failed due to URL mismatch. Expected URL pattern '/^https://fr0hfwpst1.ufs.sh/f/.+$/' but received 'https://utfs.io/f/' URL pattern
[error] 94-94: Test 'should upload a private file' failed due to URL pattern mismatch in appUrl and url fields
[error] 124-124: Test 'should upload a file from a url' failed due to incorrect URL format in response
[error] 147-147: Test 'should rename a file with fileKey' failed due to URL pattern mismatch
[error] 190-190: Test 'should rename a file with customId' failed due to incorrect URL format
[error] 231-231: Test 'should update ACL' failed due to URL pattern mismatch in response
[error] 279-279: Test 'should have correct usage info' failed. Expected totalBytes: 0, appTotalBytes: 0, filesUploaded: -1 but received different values
🪛 LanguageTool
docs/src/app/(docs)/working-with-files/page.mdx
[uncategorized] ~35-~35: Possible missing preposition found.
Context: ...mple of how to setup image optimization allow filtering in Next.js that only allows o...
(AI_HYDRA_LEO_MISSING_TO)
🔇 Additional comments (19)
playground/middleware.ts (1)
12-16:⚠️ Potential issueVerify if commenting out session validation is intentional
The commented-out session validation logic appears unrelated to the CDN URL update. If this is an intentional change, please document the rationale. Otherwise, consider reverting these changes to maintain security.
examples/minimal-expo/app/f/[key].tsx (1)
13-13: LGTM! Good use of environment variablesThe implementation correctly uses environment variables for the hostname, making it configurable across different environments.
packages/uploadthing/test/__test-helpers.ts (5)
34-37: LGTM! The URL configuration aligns with the PR objective.The constant
UFS_HOSTcorrectly handles both staging and production environments.
43-44: LGTM! The URL pattern matches the new format.The pattern correctly validates URLs in the format
https://<appId>.<UFS_HOST>/f/<fileKey>.
88-91: LGTM! The HTTP handler matches the new URL format.The handler correctly intercepts requests to the new URL pattern.
101-102: LGTM! The ingest handler uses the new URL format.Both
urlandappUrlare correctly constructed using the new URL structure.
116-116: LGTM! The file access handler uses the new URL format.The URL is correctly constructed with the new format and preserves the S3 query parameters.
packages/uploadthing/test/sdk.live.test.ts (1)
7-7: LGTM! The import statement is updated correctly.The import includes the new
UFS_HOSTconstant.packages/uploadthing/test/client.browser.test.ts (3)
143-144: LGTM! The URL expectations match the new format.The test correctly validates URLs using the new pattern.
187-188: LGTM! The URL expectations in custom headers test match the new format.The test correctly validates URLs using the new pattern.
222-223: LGTM! The URL expectations in async headers test match the new format.The test correctly validates URLs using the new pattern.
packages/uploadthing/test/request-handler.test.ts (5)
16-16: LGTM! The import statement is updated correctly.The import includes the new
UFS_HOSTconstant.
413-414: LGTM! The URLs in upload complete test use the new format.Both
urlandappUrlare correctly constructed using the new URL structure.
450-451: LGTM! The URLs in upload complete callback use the new format.Both
urlandappUrlare correctly constructed using the new URL structure.
463-464: LGTM! The URLs in missing signature test use the new format.Both
urlandappUrlare correctly constructed using the new URL structure.
496-497: LGTM! The URLs in invalid signature test use the new format.Both
urlandappUrlare correctly constructed using the new URL structure.packages/uploadthing/test/sdk.test.ts (1)
53-54: LGTM! Test cases updated correctly for new URL format.The URL construction in test assertions has been consistently updated to use the new format with
${testToken.decoded.appId}.${UFS_HOST}.Also applies to: 129-130, 263-264, 301-302, 324-325
examples/minimal-expo/.env.example (1)
2-3: LGTM! Environment variable added for new URL structure.The
EXPO_PUBLIC_UPLOADTHING_APP_IDvariable is correctly prefixed for Expo's public environment variables.docs/src/app/(docs)/concepts/regions-acl/page.mdx (1)
53-53: LGTM! Documentation updated for new URL format.The URL format has been correctly updated to use the new
APP_ID.ufs.shstructure.
| url: expect.stringMatching(fileUrlPattern(appId)), | ||
| appUrl: expect.stringMatching(fileUrlPattern(appId)), |
There was a problem hiding this comment.
Fix the failing test by updating URL expectations.
The test is failing due to URL pattern mismatch. According to the pipeline failure:
Test 'should upload a file' failed due to URL mismatch. Expected URL pattern '/^https:\/\/fr0hfwpst1.ufs.sh\/f\/.+$/' but received 'https://utfs.io/f/' URL pattern
| url: expect.stringMatching(fileUrlPattern(appId)), | ||
| appUrl: expect.stringMatching(fileUrlPattern(appId)), |
There was a problem hiding this comment.
Fix the failing test for private file upload.
The test is failing due to URL pattern mismatch according to the pipeline failure.
| url: expect.stringMatching(fileUrlPattern(appId)), | ||
| appUrl: expect.stringMatching(fileUrlPattern(appId)), |
There was a problem hiding this comment.
Fix the failing test for URL upload.
The test is failing due to incorrect URL format in response according to the pipeline failure.
| url: expect.stringMatching(fileUrlPattern(appId)), | ||
| appUrl: expect.stringMatching(fileUrlPattern(appId)), |
There was a problem hiding this comment.
Fix the failing test for file rename.
The test is failing due to URL pattern mismatch according to the pipeline failure.
| url: expect.stringMatching(fileUrlPattern(appId)), | ||
| appUrl: expect.stringMatching(fileUrlPattern(appId)), |
There was a problem hiding this comment.
Fix the failing test for custom ID.
The test is failing due to incorrect URL format according to the pipeline failure.
| url: expect.stringMatching(fileUrlPattern(appId)), | ||
| appUrl: expect.stringMatching(fileUrlPattern(appId)), |
There was a problem hiding this comment.
Fix the failing test for ACL update.
The test is failing due to URL pattern mismatch according to the pipeline failure.
| const response = await fetch( | ||
| `https://${testToken.decoded.appId}.${UFS_HOST}/f/${someFile.key}`, | ||
| ); |
There was a problem hiding this comment.
Fix the failing test for file deletion.
The test is failing. The usage info test indicates incorrect values for totalBytes and filesUploaded according to the pipeline failure.
|
once the infra has been deployed the live tests will pass |
Summary by CodeRabbit
Infrastructure
utfs.ioto a new domain format<APP_ID>.ufs.shEXPO_PUBLIC_UPLOADTHING_APP_IDfor dynamic URL generationDocumentation
Testing