Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor bundling to improve old moduleResolution support #579

Merged
merged 47 commits into from
Feb 5, 2024

Conversation

juliusmarminge
Copy link
Collaborator

@juliusmarminge juliusmarminge commented Jan 26, 2024

Required for #583

  • Bundled files are now in top-level to support resolutions that doesn't look in package.json#exports: (I've enabled a setting to hide ignored files from the explorer to keep the file tree tidy)
    CleanShot 2024-01-29 at 09 53 15@2x

  • use vitest workspaces for testing cause why not

Copy link

changeset-bot bot commented Jan 26, 2024

⚠️ No Changeset found

Latest commit: 80272e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2024 9:52pm

@juliusmarminge
Copy link
Collaborator Author

juliusmarminge commented Jan 29, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@@ -5,6 +5,7 @@
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": true,
"eslint.rules.customizations": [{ "rule": "*", "severity": "warn" }],
"explorer.excludeGitIgnore": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I feel about this, but will give it a try.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to revert it if you don't like it

@juliusmarminge juliusmarminge merged commit 44cc476 into main Feb 5, 2024
15 checks passed
juliusmarminge added a commit that referenced this pull request Feb 7, 2024
@juliusmarminge juliusmarminge deleted the expoo branch February 29, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants