Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tap to v18 #166

Closed
wants to merge 1 commit into from
Closed

update tap to v18 #166

wants to merge 1 commit into from

Conversation

balaji-atoa
Copy link

@balaji-atoa balaji-atoa commented Nov 10, 2024 •
edited
Loading

🚀UPDATES:

  • updated tap to v18

@balaji-atoa
Copy link
Author

balaji-atoa commented Nov 10, 2024 •
edited
Loading

any idea why this fails? @mcollina

image

jsumners
jsumners requested changes Nov 10, 2024
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. As an organization, we'd prefer to migrate our tests to node:test.

@balaji-atoa
Copy link
Author

@jsumners will work on this when i get time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balaji-atoa @jsumners