Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11050] Extract FilterView from FilteredServerMap #11142

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 11, 2024

No description provided.

@emeroad emeroad added this to the 3.0.1 milestone Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 40 lines in your changes missing coverage. Please review.

Project coverage is 37.07%. Comparing base (0235e19) to head (661b389).

Files Patch % Lines
...orp/pinpoint/web/applicationmap/FilterMapWrap.java 0.00% 17 Missing ⚠️
...nt/web/applicationmap/view/ScatterDataMapView.java 0.00% 9 Missing ⚠️
...plicationmap/controller/FilteredMapController.java 0.00% 7 Missing ⚠️
...point/web/applicationmap/SimpleApplicationMap.java 71.42% 2 Missing ⚠️
...oint/web/applicationmap/DefaultApplicationMap.java 85.71% 1 Missing ⚠️
...point/web/applicationmap/FilterMapWithScatter.java 83.33% 1 Missing ⚠️
...navercorp/pinpoint/web/applicationmap/MapWrap.java 0.00% 1 Missing ⚠️
...applicationmap/service/FilteredMapServiceImpl.java 66.66% 1 Missing ⚠️
...web/applicationmap/view/FilteredHistogramView.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11142      +/-   ##
============================================
+ Coverage     37.05%   37.07%   +0.02%     
- Complexity    11990    11992       +2     
============================================
  Files          3948     3947       -1     
  Lines         97301    97255      -46     
  Branches      10387    10380       -7     
============================================
+ Hits          36051    36054       +3     
+ Misses        58288    58242      -46     
+ Partials       2962     2959       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad merged commit 023f7e1 into pinpoint-apm:master Jun 11, 2024
1 of 2 checks passed
@emeroad emeroad linked an issue Jun 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract JsonSerializer from ServerMap into View Class
1 participant