Merge pull request #103 from pinpt/less-error

remove impossible error from NewDateWithTime⏰

datetime/time.go

@@ -340,13 +340,13 @@ func NewDate(val string) (*Date, error) {
 }
 
 // NewDateWithTime returns a new Date object from a time.Time value
-func NewDateWithTime(tv time.Time) (*Date, error) {
+func NewDateWithTime(tv time.Time) *Date {
 	_, timezone := tv.Zone()
 	return &Date{
 		Epoch:   TimeToEpoch(tv),
 		Rfc3339: tv.Round(time.Millisecond).Format(RFC3339),
 		Offset:  int64(timezone) / 60,
-	}, nil
+	}
 }
 
 // NewDateFromEpoch returns a new Date object from a epoch time value
@@ -381,8 +381,7 @@ func ConvertToModel(ts time.Time, dateModel interface{}) {
 		return
 	}
 
-	// this always returns nil
-	date, _ := NewDateWithTime(ts)
+	date := NewDateWithTime(ts)
 
 	t := reflect.ValueOf(dateModel).Elem()
 	t.FieldByName("Rfc3339").Set(reflect.ValueOf(date.Rfc3339))

datetime/time_test.go

@@ -163,8 +163,7 @@ func TestDateObject(t *testing.T) {
 	dt3 := DateFromEpoch(date3.Epoch)
 	assert.WithinDuration(dt3, time.Now(), time.Second)
 	assert.Equal(int64(0), date3.Offset) // make sure ISO returns GMT timezone
-	dt4, err := NewDateWithTime(dt)
-	assert.NoError(err)
+	dt4 := NewDateWithTime(dt)
 	assert.Equal(date1.Epoch, dt4.Epoch)
 }