fix: move workflow link to source query tab #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
May 2, 2024
| @@ -80,6 +81,21 @@ export const DataTableViewSourceQuery: React.FunctionComponent<IProps> = ({ | |||
| ); | |||
| }); | |||
|
|
|||
| const customProperties = table.custom_properties ?? {}; | |||
| const workflowValue = customProperties['workflow']?.toString() ?? null; | |||
There was a problem hiding this comment.
nit: the workflow is already a string I think?
There was a problem hiding this comment.
custom_property values are string | number, so change to string type for Link component
There was a problem hiding this comment.
@zhangvi7 it doesn't make sense to convert if it is a number
There was a problem hiding this comment.
updated to use typeof to assert string type
querybook/webapp/components/DataTableViewSourceQuery/DataTableViewSourceQuery.tsx
Show resolved
Hide resolved
| const workflowValue = customProperties['workflow']?.toString() ?? null; | ||
| const workflowDOM = workflowValue ? ( | ||
| <div className="DataTableViewSourceQuery-workflow"> | ||
| <div className="data-job-source-query-top"> |
There was a problem hiding this comment.
this class data-job-source-query-top is from component DataJobMetadataInfo, looks weird to be here. better to define its own.
czgu
reviewed
May 3, 2024
querybook/webapp/components/DataTableViewSourceQuery/DataTableViewSourceQuery.tsx
Outdated
Show resolved
Hide resolved
| @@ -80,6 +81,21 @@ export const DataTableViewSourceQuery: React.FunctionComponent<IProps> = ({ | |||
| ); | |||
| }); | |||
|
|
|||
| const customProperties = table.custom_properties ?? {}; | |||
| const workflowValue = customProperties['workflow']?.toString() ?? null; | |||
There was a problem hiding this comment.
@zhangvi7 it doesn't make sense to convert if it is a number
czgu
reviewed
May 3, 2024
| Workflow | ||
| </Title> | ||
| </div> | ||
| {/https?:\/\/[^\s]+/.test(workflowValue.trim()) ? ( |
jczhong84
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ER-7007] Minor Querybook Improvements for Tier 1 tables
Test Plan
Added workflow link to bottom of source query tab