fix: move slack channel to top of table description #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
May 2, 2024
| const channelsKey = 'channels'; | ||
| const channelsValue = customProperties[channelsKey]?.toString() ?? ''; | ||
| const channelsName = channelsValue.slice(1); | ||
| const channelLink = `https://pinterest.slack.com/app_redirect?channel=${channelsName}`; |
There was a problem hiding this comment.
this is too Pinterest specific for the opensource repo and need a better solution for it. let's not add a link for now. maybe can add link in the properties when syncing from pincat
There was a problem hiding this comment.
removed link for now
jczhong84
previously approved these changes
May 3, 2024
czgu
requested changes
May 3, 2024
Comment on lines
85
to
98
| function createChannelLinkDOM(customProperties) { | ||
| const channelsKey = 'channels'; | ||
| const channelsValue = customProperties[channelsKey]?.toString() ?? ''; | ||
|
|
||
| return channelsValue === '' ? null : ( | ||
| <KeyContentDisplay | ||
| key={channelsKey} | ||
| keyString={titleize(channelsKey, '_', ' ')} | ||
| > | ||
| {channelsValue} | ||
| </KeyContentDisplay> | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
this is duplicating a lot of code specially for channels, could you have something like:
/**
* any custom properties in this array will be shown on top following the order of the array
*/
const pinnedCustomProperties = ['channels'];
then when you go over customPropertiesDOM, make orderedProperties show at the beginning
There was a problem hiding this comment.
- Refactored KeyContentDisplay to helper
- Added
pinnedCustomProperties[]to display pinned custom properties at top and unpinned custom properties at bottom - Updated test plan with screenshots
czgu
reviewed
May 6, 2024
querybook/webapp/components/DataTableViewOverview/DataTableViewOverview.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/components/DataTableViewOverview/DataTableViewOverview.tsx
Outdated
Show resolved
Hide resolved
|
czgu
reviewed
May 7, 2024
czgu
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor Querybook Improvements for Tier 1 tables
Test Plan
Bring slack channel to top of table details and add channel link