Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade flake8 to latest #1498

Merged
merged 1 commit into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ repos:
# - '@trivago/prettier-plugin-sort-imports@3.2.0' # removing it since pre-commit install fails

- repo: https://github.com/PyCQA/flake8
rev: 3.9.2
rev: 7.1.1
hooks:
- id: flake8
files: "^querybook/(server|tests)/.*\\.py$"
Expand Down
2 changes: 1 addition & 1 deletion querybook/server/app/auth/oauth_auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def oauth_callback(self):
LOG.debug("Handling Oauth callback...")

if request.args.get("error"):
return f"<h1>Error: { Markup.escape(request.args.get('error')) }</h1>"
return f"<h1>Error: {Markup.escape(request.args.get('error'))}</h1>"

code = request.args.get("code")
try:
Expand Down
2 changes: 1 addition & 1 deletion querybook/server/app/auth/okta_auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def oauth_callback(self):
LOG.debug("Handling Oauth callback...")

if request.args.get("error"):
return f"<h1>Error: { Markup.escape(request.args.get('error')) }</h1>"
return f"<h1>Error: {Markup.escape(request.args.get('error'))}</h1>"

code = request.args.get("code")
try:
Expand Down
2 changes: 1 addition & 1 deletion querybook/server/logic/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def get_all_visible_environments_by_uid(uid, session=None):
or_(
Environment.hidden != True, # noqa: E712
UserEnvironment.user_id == uid,
Environment.public == True,
Environment.public == True, # noqa: E712
)
)
.all()
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ ignore=
E241,
E305,
E402,
E721,
E722,
E741,
N801,
Expand Down
Loading