feat: upgrade codemirror 5 to codemirror 6 #1510
Open
+1,718
−1,696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Nov 8, 2024
Comment on lines
+66
to
+76
| if (language && language in functionDocumentationByNameByLanguage) { | ||
| const functionDefs = | ||
| functionDocumentationByNameByLanguage[language]; | ||
| const functionNameLower = (functionName || '').toLowerCase(); | ||
|
|
||
| if (functionNameLower in functionDefs) { | ||
| return functionDefs[functionNameLower]; | ||
| } | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
Suggested change
| if (language && language in functionDocumentationByNameByLanguage) { | |
| const functionDefs = | |
| functionDocumentationByNameByLanguage[language]; | |
| const functionNameLower = (functionName || '').toLowerCase(); | |
| if (functionNameLower in functionDefs) { | |
| return functionDefs[functionNameLower]; | |
| } | |
| } | |
| return null; | |
| const functionDefs = functionDocumentationByNameByLanguage?.[language]; | |
| const functionNameLower = (functionName || '').toLowerCase(); | |
| return functionDefs?.[functionNameLower]; |
There was a problem hiding this comment.
also useCallback is not needed with above code
| } | ||
|
|
||
| if (lintSummary.numErrors + lintSummary.numWarnings > 0) { | ||
| return ( |
| export const useAutoCompleteExtension = ({ view, autoCompleterRef }) => { | ||
| const [typing, setTyping] = useState(false); | ||
|
|
||
| const getCompletions = useCallback(async (context) => { |
There was a problem hiding this comment.
import {CompletionContext} from "@codemirror/autocomplete"?
Comment on lines
+33
to
+48
| if (tableInfo.line === line) { | ||
| const isSchemaExplicit = | ||
| tableInfo.end - tableInfo.start > | ||
| tableInfo.name.length; | ||
| const tablePos = { | ||
| from: | ||
| tableInfo.start + | ||
| (isSchemaExplicit | ||
| ? tableInfo.schema.length | ||
| : 0), | ||
| to: tableInfo.end, | ||
| }; | ||
|
|
||
| if (tablePos.from <= ch && tablePos.to >= ch) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (tableInfo.line === line) { | |
| const isSchemaExplicit = | |
| tableInfo.end - tableInfo.start > | |
| tableInfo.name.length; | |
| const tablePos = { | |
| from: | |
| tableInfo.start + | |
| (isSchemaExplicit | |
| ? tableInfo.schema.length | |
| : 0), | |
| to: tableInfo.end, | |
| }; | |
| if (tablePos.from <= ch && tablePos.to >= ch) { | |
| return true; | |
| } | |
| if (tableInfo.line !== line) return false; | |
| const isSchemaExplicit = | |
| tableInfo.end - tableInfo.start > | |
| tableInfo.name.length; | |
| const tablePos = { | |
| from: | |
| tableInfo.start + | |
| (isSchemaExplicit | |
| ? tableInfo.schema.length | |
| : 0), | |
| to: tableInfo.end, | |
| }; | |
| return tablePos.from <= ch && tablePos.to >= ch; |
Comment on lines
+91
to
+93
| } else { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
if (!tooltipComponent) return null;
| const lastPart = parts[parts.length - 1]; | ||
|
|
||
| // Check if the last part is a single alphabetical character | ||
| if (lastPart.length === 1 && /[a-zA-Z]/.test(lastPart)) { |
| import { isEqual } from 'lodash'; | ||
| import { useEffect, useRef } from 'react'; | ||
|
|
||
| export default function useDeepCompareEffect(callback, dependencies) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the query editor to use codemirror6, changes cover below editor features and most of them will have the same user experience
some screenshots
linter error and summary status bar
table hover
auto complete
search highlight
