Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent heap allocations in FiveTuple Fingerprint #390

Closed
wants to merge 1 commit into from

Conversation

paulwe
Copy link
Contributor

@paulwe paulwe commented Apr 19, 2024

No description provided.

@paulwe paulwe requested review from davidzhao and boks1971 April 19, 2024 23:43
@paulwe paulwe force-pushed the five-tuple-fingerprint branch from c47bf13 to 709f89a Compare April 19, 2024 23:48
@paulwe paulwe changed the title Prevent heap allocations from FiveTuple Fingerprint Prevent heap allocations in FiveTuple Fingerprint Apr 19, 2024
internal/allocation/five_tuple.go Outdated Show resolved Hide resolved
internal/allocation/five_tuple.go Outdated Show resolved Hide resolved
@paulwe paulwe force-pushed the five-tuple-fingerprint branch 4 times, most recently from 4fa279a to 1a7b9ee Compare April 20, 2024 00:02
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 27.87%. Comparing base (cf40c33) to head (a9f47d0).

Files Patch % Lines
internal/allocation/five_tuple.go 72.22% 5 Missing ⚠️
internal/allocation/allocation_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #390       +/-   ##
===========================================
- Coverage   68.24%   27.87%   -40.38%     
===========================================
  Files          43       43               
  Lines        2337     2353       +16     
===========================================
- Hits         1595      656      -939     
- Misses        576     1652     +1076     
+ Partials      166       45      -121     
Flag Coverage Δ
go ?
wasm 27.87% <68.42%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulwe paulwe force-pushed the five-tuple-fingerprint branch from 1a7b9ee to a9f47d0 Compare April 20, 2024 00:11
@paulwe paulwe closed this Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants