Skip to content
This repository has been archived by the owner on Jun 21, 2022. It is now read-only.

Deploy to master w/ new release- tag #639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

scottnuma
Copy link
Contributor

  • Previously, we created a GitHub workflow to deploy to staging when we create a release with the release prefix and then an authorized approver approves
  • Let's do the same, but now for prod
  • Example flow:
    • Developer merges PR and creates a new release: release-something
    • Admin approves deploying staging
    • The deploy-staging workflow runs and the change is live on staging-website.pierobotics.org
    • Developer verifies change
    • Admin approves deploying production
    • The deploy-production workflow runs and the change is live on pioneers.berkeley.edu

@render
Copy link

render bot commented Aug 17, 2021

@dwai213
Copy link
Contributor

dwai213 commented Aug 17, 2021

For clarification, is there a particular naming convention we have to follow for the release name?
Should there be a release naming convention for developers that just want to use the deploy-staging flow to preview their code changes?

Copy link
Contributor

@quantumfusion quantumfusion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should make it part of this PR, but shouldn't we change the push-staging workflow to look for a different tag? It currently appears to have the same restrictions on when to run: https://github.com/pioneers/website/blob/master/.github/workflows/push-staging.yml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants