-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very WIP: Refactor flight log recover #5775
Draft
JonBooth78
wants to merge
6
commits into
pioneerspacesim:master
Choose a base branch
from
JonBooth78:refactor-flight-log-recover
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Very WIP: Refactor flight log recover #5775
JonBooth78
wants to merge
6
commits into
pioneerspacesim:master
from
JonBooth78:refactor-flight-log-recover
Commits on Feb 11, 2024
-
Remember lua object types when recovery savegame
In the fixupDoc function, serialized Lua objects are turned into regular tables, and type information is lost. But it turned out to be needed to restore the v90 flight log, since it uses a single "polymorphic" array of records.
Configuration menu - View commit details
-
Copy full SHA for bd7f619 - Browse repository at this point
Copy the full SHA bd7f619View commit details
Commits on Feb 13, 2024
-
Rename some fields in flightlog game param
The v90 flight log uses a hash table for the entries and the names of some fields do not match those from the recovery. Renamed in recovery related routines for compatibility: - rename arbitrary field from 'text' to 'entry' - in the station log, change the 'time' field to 'deptime'
Configuration menu - View commit details
-
Copy full SHA for 604bfc8 - Browse repository at this point
Copy the full SHA 604bfc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e1eb6d - Browse repository at this point
Copy the full SHA 7e1eb6dView commit details
Commits on Feb 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 101b552 - Browse repository at this point
Copy the full SHA 101b552View commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e718ae6 - Browse repository at this point
Copy the full SHA e718ae6View commit details
Commits on Feb 21, 2024
-
WIP: Consolidate much flightlog ralated logic into the flightlog code…
… and out of the new-game window. The goal is to enact DRY, reducing the duplicated logic for rendering and serialzation of the flight log and cosolidating into one place. So this: * Moved serialization (of which recovery is one version) of the flightlog into the flightlog code * Moves rendering of the flighog in the new-window screen to use the flight log rendering code There are still some issues and ugly coupling remainng of the new-game window code and the flightog that needs unpicking around how we access the galaxy object to format log entries. Perthaps we should do this once as the flight log entries are created, rather than on demand eavh frame of rendering. This would help us clean up those dependencies.
Configuration menu - View commit details
-
Copy full SHA for dc2ad32 - Browse repository at this point
Copy the full SHA dc2ad32View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.