Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very WIP: Refactor flight log recover #5775

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Feb 11, 2024

  1. Remember lua object types when recovery savegame

    In the fixupDoc function, serialized Lua objects are turned into regular
    tables, and type information is lost. But it turned out to be needed to
    restore the v90 flight log, since it uses a single "polymorphic" array
    of records.
    Gliese852 committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    bd7f619 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Rename some fields in flightlog game param

    The v90 flight log uses a hash table for the entries and the names of
    some fields do not match those from the recovery. Renamed in recovery
    related routines for compatibility:
    
      - rename arbitrary field from 'text' to 'entry'
    
      - in the station log, change the 'time' field to 'deptime'
    Gliese852 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    604bfc8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e1eb6d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Configuration menu
    Copy the full SHA
    101b552 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Configuration menu
    Copy the full SHA
    e718ae6 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. WIP: Consolidate much flightlog ralated logic into the flightlog code…

    … and out of the new-game window.
    
    The goal is to enact DRY, reducing the duplicated logic for rendering and serialzation of the flight log and cosolidating into one place.
    
    So this:
     * Moved serialization (of which recovery is one version) of the flightlog into the flightlog code
     * Moves rendering of the flighog in the new-window screen to use the flight log rendering code
    
    There are still some issues and ugly coupling remainng of the new-game window code and the flightog that needs unpicking around how we access the galaxy object to format log entries.  Perthaps we should do this once as the flight log entries are created, rather than on demand eavh frame of rendering.  This would help us clean up those dependencies.
    JonBooth78 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    dc2ad32 View commit details
    Browse the repository at this point in the history