Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unique names for utility programs #5826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented Apr 23, 2024

Prefix modelcompiler, savegamedump, editor binary names with pioneer- to avoid too generic names which may conflict with other packages when installed into system.

Prefix modelcompiler, savegamedump, editor binary names with `pioneer-`
to avoid too generic names which may conflict with other packages when
installed into system.
@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Apr 23, 2024

Could not fix the build on msvc. No idea why it uses base binary name while generator expression should return real output name. Probably we can fix it by renaming targets if that's ok.

@impaktor
Copy link
Member

Yup, I agree.

Would also have to change editor.txt, and COMPILING.txt. (I could push a commit for that)
(and wiki, and maybe devdocs, but can do that after merge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants