Station Police view has tabs: 1. crime records, + new: 2. rules & regulations #5863
Conversation
|
thoughts:
|
|
Like so |
|
Will review this after the UI theme PR is merged. I like what I'm seeing here, but some areas could have improved formatting - I'll see if I can address that. |
|
Looks nice! I would consider sorting the lists. |
impaktor
force-pushed
the
rules_explicit
branch
from
44090cd
to
acba189
Compare
|
rebased to new theme on master. No changes beyond that.... |
There was a problem hiding this comment.
Going to be cheeky and approve my own changes here too - made stylistic and textual changes as needed for a uniform standard of quality across the entire tab. This PR is definitely a good change, but the whole station view UI is desperately in need of a redesign in the long term.
Final(ish) appearance:
|
And yes, the faces are different in each screenshot because every time you do a debug reload of the police tab, the station gets a different constable 😄 |
- If a transformer function returned a modified key, that key was accidentally fed back into the next call to the underlying iterator - Fix occurrences of two-space indentation / mis-indentation
- Render crime lists as tables - Use ui.tabBarFont() for consistent styling of the tab bar - Show fine cost on payment button and change state based on player monetary state - Sort criminal records by count of crimes committed - Sort list of illegal commodities alphabetically - Add introductory text to illegal commodity list - Tweak rules/regulations text to mention that the distance pertains to laws enforced within the station's sensor coverage.
impaktor
force-pushed
the
rules_explicit
branch
from
20624a7
to
7e5fa35
Compare
I found this 4 year old branch. I figured I could fix it up and PR it.
This aims to show more clearly what rules the player need to be weary of. Changes:
(Never mind my Evarchart facemod)
