Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with error status code when plan preview failed #4660

Closed
TakumaKurosawa opened this issue Nov 8, 2023 · 3 comments
Closed

Exit with error status code when plan preview failed #4660

TakumaKurosawa opened this issue Nov 8, 2023 · 3 comments
Labels
kind/enhancement New feature or request

Comments

@TakumaKurosawa
Copy link
Contributor

What would you like to be added:
Call os.Exit(1) when plan-preview sent an error message.

Why is this needed:
Plan preview CI send error comment but workflow is still succeeded.
So we have to exit with error status code when exception case.

@TakumaKurosawa
Copy link
Contributor Author

I'd like to work on this.
I've already make PR: #4659

Copy link
Contributor

github-actions bot commented May 7, 2024

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 7, 2024
@t-kikuc
Copy link
Member

t-kikuc commented May 7, 2024

This is already solved.

@t-kikuc t-kikuc closed this as completed May 7, 2024
@t-kikuc t-kikuc removed the Stale label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants