Exit with error status code when plan preview failed #4659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TakumaKurosawa
requested review from
nghialv,
khanhtc1202,
kentakozuka and
ffjlabo
as code owners
|
@TakumaKurosawa Thanks for the great contributions to plan-preview codebase 😄 |
TakumaKurosawa
force-pushed
the
os-exit-when-error-occurred
branch
from
75c3f40
to
88d7fb6
Compare
|
@khanhtc1202 |
|
@khanhtc1202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Plan preview CI send error comment but workflow is still succeeded.
So we have to exit with error status code when exception case.
Which issue(s) this PR fixes:
Fixes #4660
Does this PR introduce a user-facing change?: