Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go test command #4514

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Update go test command #4514

merged 3 commits into from
Jul 20, 2023

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@69bce19). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4514   +/-   ##
=========================================
  Coverage          ?   30.01%           
=========================================
  Files             ?      220           
  Lines             ?    25761           
  Branches          ?        0           
=========================================
  Hits              ?     7733           
  Misses            ?    17382           
  Partials          ?      646           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
kentakozuka
kentakozuka previously approved these changes Jul 20, 2023
Copy link
Member

@kentakozuka kentakozuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202
Copy link
Member Author

@kentakozuka Please re-approve 🙏 I just revert the change on gitignore

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) July 20, 2023 01:35
Copy link
Member

@kentakozuka kentakozuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khanhtc1202 khanhtc1202 merged commit 80aaebf into master Jul 20, 2023
14 checks passed
@khanhtc1202 khanhtc1202 deleted the update-test-command branch July 20, 2023 02:15
hungran pushed a commit to hungran/pipecd that referenced this pull request Jul 21, 2023
* Update go test command

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Update makefile and github action command

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Revert gitignore

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
khanhtc1202 added a commit that referenced this pull request Jul 24, 2023
…sn't exist (#4504)

* feat: add spec input.AutoCreateNamespace for creating a ns when doesn't exist

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* not return error when namespace already exists

Signed-off-by: hungran <vmhung290791@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* not return err

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* WIP
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* omitempty AutoCreateNamespace, add test case

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* test data k8s-app-helm.yaml

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Redirect /docs/ to /docs-{latest}/ (#4495)

* Redirect /docs/ to /docs-{latest}/

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Fix use local path

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

---------

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Fix documentation link is not displayed (#4505)

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update docs/content/en/docs-dev/user-guide/configuration-reference.md

Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_kubernetes.go

Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_kubernetes_test.go

Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Bump word-wrap from 1.2.3 to 1.2.4 in /web (#4511)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Setup codecov (#4509)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* add: caution note to user group doc (#4512)

Signed-off-by: seitarof <pyotarou@icloud.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update go test command (#4514)

* Update go test command

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Update makefile and github action command

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Revert gitignore

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Fix make release/docs command regenerate unused docs directory (#4513)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update auth docs (#4517)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Add Google Tag Manager to the site (#4519)

* Add Google Tag Manager to the site

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Add breakline

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Add breakline

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

---------

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_kubernetes_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* get value from var not from pointer

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* handle error when namespace already exsist and ignore it

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* rename handle err, remove unessacarry value test

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* if true

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* fix test data

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* fix correct the test case

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* remove unuse value in k8s-app-helm

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

---------

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
Signed-off-by: hungran <vmhung290791@gmail.com>
Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: seitarof <pyotarou@icloud.com>
Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Seitaro Fujigaki <51070449+seitarof@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
moko-poi pushed a commit to moko-poi/pipecd that referenced this pull request Nov 3, 2023
…sn't exist (pipe-cd#4504)

* feat: add spec input.AutoCreateNamespace for creating a ns when doesn't exist

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* not return error when namespace already exists

Signed-off-by: hungran <vmhung290791@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* not return err

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* WIP
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* omitempty AutoCreateNamespace, add test case

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* test data k8s-app-helm.yaml

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Redirect /docs/ to /docs-{latest}/ (pipe-cd#4495)

* Redirect /docs/ to /docs-{latest}/

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Fix use local path

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

---------

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Fix documentation link is not displayed (pipe-cd#4505)

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update docs/content/en/docs-dev/user-guide/configuration-reference.md

Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_kubernetes.go

Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_kubernetes_test.go

Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Bump word-wrap from 1.2.3 to 1.2.4 in /web (pipe-cd#4511)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Setup codecov (pipe-cd#4509)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* add: caution note to user group doc (pipe-cd#4512)

Signed-off-by: seitarof <pyotarou@icloud.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update go test command (pipe-cd#4514)

* Update go test command

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Update makefile and github action command

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Revert gitignore

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Fix make release/docs command regenerate unused docs directory (pipe-cd#4513)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update auth docs (pipe-cd#4517)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Add Google Tag Manager to the site (pipe-cd#4519)

* Add Google Tag Manager to the site

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Add breakline

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

* Add breakline

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>

---------

Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_kubernetes_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* Update pkg/config/application_test.go

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* get value from var not from pointer

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* handle error when namespace already exsist and ignore it

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* rename handle err, remove unessacarry value test

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* if true

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* fix test data

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* fix correct the test case

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

* remove unuse value in k8s-app-helm

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

---------

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>
Signed-off-by: hungran <vmhung290791@gmail.com>
Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: seitarof <pyotarou@icloud.com>
Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Seitaro Fujigaki <51070449+seitarof@users.noreply.github.com>
Signed-off-by: moko-poi <mokopoi44@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants