-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus metrics lists to docs #4533
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4533 +/- ##
==========================================
- Coverage 30.00% 29.98% -0.02%
==========================================
Files 220 220
Lines 25808 25808
==========================================
- Hits 7743 7739 -4
- Misses 17418 17422 +4
Partials 647 647 ☔ View full report in Codecov by Sentry. |
|
||
| Metric | Type | Description | | ||
| --- | --- | --- | | ||
| `deployment_status` | gauge | The current status of deployment. 1 for current status, 0 for others. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about other metrics of piped. We serve other as well
https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/cmd/piped/piped.go#L815-L821
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I missed them.
|
||
| Metric | Type | Description | | ||
| --- | --- | --- | | ||
| `insight_application_total` | gauge | Number of applications currently controlled by control plane. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, we have others metrics of controlplane as well
https://github.com/pipe-cd/pipecd/blob/master/cmd/pipecd/server.go#L512-L518
@khanhtc1202 Other metrics added 👍 |
That would be great 👍 |
Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com>
d0e7110
to
2d9ef7d
Compare
@khanhtc1202 Fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ❤️
* Add prometheus metrics lists to docs Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add missing metrics Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Move metric docs to under user guide Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
* Add prometheus metrics lists to docs Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add missing metrics Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Move metric docs to under user guide Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4516
Does this PR introduce a user-facing change?: