Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty line to fix the CI gen #4972

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Add empty line to fix the CI gen #4972

merged 1 commit into from
Jun 14, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Jun 14, 2024

What this PR does / why we need it:

This PR expects to fix the CI gen fails.
This is just a workaround to pass CI.

How to reproduce

  • build the image for with linux/amd64 docker buildx.
  • Fix Makefile and execute make gen/code.
docker buildx build --platform linux/amd64 tool/codegen -t codegen-buildx-amd

Fix the Makefile like this↓

gen/code:
	# NOTE: Specify a specific version temporally until the next release.
	docker run --rm -v ${PWD}:/repo -it --entrypoint ./tool/codegen/codegen.sh codegen-buildx-amd  /repo #v0.44.0-38-g7229285

Which issue(s) this PR fixes:

Related to #4970

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.32%. Comparing base (7e27cad) to head (7455ff7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4972   +/-   ##
=======================================
  Coverage   29.32%   29.32%           
=======================================
  Files         323      323           
  Lines       40984    40984           
=======================================
  Hits        12018    12018           
  Misses      28005    28005           
  Partials      961      961           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-kikuc t-kikuc changed the title Add empty line Add empty line to fix the CI gen Jun 14, 2024
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reproduced the fix on my local machine!
Thank you!

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, what a strange problem...

@ffjlabo
Copy link
Member Author

ffjlabo commented Jun 14, 2024

Thank you both 🙏
I will check the result on the #4970

@ffjlabo ffjlabo merged commit 462b842 into master Jun 14, 2024
23 of 25 checks passed
@ffjlabo ffjlabo deleted the add-empty-line branch June 14, 2024 02:19
@github-actions github-actions bot mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants